[Bug 707605] Need "reverse-funnel" element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707605
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258711|none                        |needs-work
             status|                            |

--- Comment #57 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-01 13:42:02 UTC ---
Review of attachment 258711:
 --> (https://bugzilla.gnome.org/review?bug=707605&attachment=258711)

Generally looks good now, just some comments for the test

::: tests/check/elements/streamiddemux.c
@@ +48,3 @@
+    gst_object_unref (active_srcpad);
+
+  g_object_get (td->demux, "active-pad", &active_srcpad, NULL);

You're leaking this in the end of the tests

@@ +190,3 @@
+    set_active_srcpad (&td);
+
+    fail_unless (gst_pad_push (td.mysrc, gst_buffer_new ()) == GST_FLOW_OK);

Check that the active srcpad after pushing is the one you expect

@@ +201,3 @@
+    set_active_srcpad (&td);
+
+    fail_unless (gst_pad_push (td.mysrc, gst_buffer_new ()) == GST_FLOW_OK);

Check that the active srcpad after pushing is the one you expect

@@ +206,3 @@
+  GST_DEBUG ("Releasing mysink and mysrc");
+  stream_cnt = 0;
+  while (stream_cnt < NUM_SUBSTREAMS) {

Just make this a for loop, also elsewhere

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.