[Bug 711211] avfvideosrc: use input device formats to set/get caps instead of session presets

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 5 08:44:38 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=711211
  GStreamer | gst-plugins-bad | git

--- Comment #8 from Matthieu Bouron <matthieu.bouron at collabora.com> 2013-11-05 16:44:33 UTC ---
(In reply to comment #4)
> Review of attachment 258929 [details]:
> 
> ::: sys/applemedia/avfvideosrc.m
> @@ +351,3 @@
> +              found_framerate = TRUE;
> +              device.activeVideoMinFrameDuration = rate.minFrameDuration;
> +              device.activeVideoMaxFrameDuration = rate.maxFrameDuration;
> 
> This API is only available in OS X 10.9 and IOS 7.0, so you should these
> property using key-value coding [1] either with try catch or with runtime
> detection of the current version [2]

The whole API using device formats and activeFormat is available from OS X 10.7
(according to the documentation) and from IOS 7.0. So if we want to support iOS
< 7.0 we need to keep the old code using the session presets.

The question is, do we want to support other version of IOS other than 7.0 ?
considering the maintenance burden of having both code path.

> 
> [1]
> https://developer.apple.com/library/mac/documentation/cocoa/reference/foundation/Protocols/NSKeyValueCoding_Protocol/Reference/Reference.html#//apple_ref/occ/instm/NSObject/setValue:forKey:
> 
> [2]
> https://developer.apple.com/library/mac/documentation/developertools/conceptual/cross_development/Using/using.html

Thanks for the helpful links.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list