[Bug 711693] [PATCH] rtpsession: Implement various session statistics

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711693
  GStreamer | gst-plugins-good | unspecified

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259282|none                        |needs-work
             status|                            |

--- Comment #2 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2013-11-08 16:26:56 UTC ---
Review of attachment 259282:
 --> (https://bugzilla.gnome.org/review?bug=711693&attachment=259282)

::: gst/rtpmanager/gstrtpsession.c
@@ +835,3 @@
+      break;
+    case PROP_RECV_NACK_COUNT:
+      g_object_set_property (G_OBJECT (priv->session), "nacks-recieved",
value);

You probably need g_object_get_property in all 3 cases

::: gst/rtpmanager/rtpsession.c
@@ +707,3 @@
+      break;
+    case PROP_NACKS_SENT:
+      g_value_set_uint (value, sess->stats.nacks_dropped);

s/dropped/sent/

::: gst/rtpmanager/rtpsession.h
@@ +284,3 @@
       guint sender_ssrc, guint media_ssrc, GstBuffer *fci);
   void (*send_rtcp)         (RTPSession *sess, GstClockTime max_delay);
+  void (*on_nack_dropped)   (RTPSession *sess, guint count);

Where is that being used?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.