[Bug 711699] wavenc: bogus header generated

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711699
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259287|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-09 09:58:20 UTC ---
Review of attachment 259287:
 --> (https://bugzilla.gnome.org/review?bug=711699&attachment=259287)

::: gst/wavenc/gstwavenc.c
@@ +896,3 @@
       wavenc->rate = 0;
       wavenc->audio_length = 0;
+      wavenc->meta_length = 0x7FFF0000;

I think you want to initialize audio_length here. But also it has to be reset
to 0 after pushing the initial header because later it is only incremented
(same as meta_length, both only get += buffer_size).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.