[Bug 708914] Add openni2 plugin and openni2src element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708914
  GStreamer | gst-plugins-bad | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259096|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-09 10:20:32 UTC ---
(From update of attachment 259096)
Bugzilla's review functionality breaks on that patch for some reason :(


In get_caps() it's not enough to just return the cached caps. For every call
you must intersect the result with the filter caps before returning, see other
get_caps functions everywhere.
You can also just use the GST_OBJECT_LOCK() instead of adding your own mutex
(which btw needs a g_mutex_clear() call in the finalize or dispose function).


gst_buffer_map() is enough to be called with GST_MAP_WRITE, you do no reading.
Not that it matters much here but just for cleaner code :)

You should make sure that the strides for openni are the same as for GStreamer,
and otherwise convert between them.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.