[Bug 711412] [PATCH] rtpjitterbuffer: Automatically calculate RTX properties based on RTT

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711412
  GStreamer | gst-plugins-good | unspecified

Wim Taymans <wim.taymans> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258933|none                        |needs-work
             status|                            |

--- Comment #2 from Wim Taymans <wim.taymans at gmail.com> 2013-11-11 14:14:13 UTC ---
Review of attachment 258933:
 --> (https://bugzilla.gnome.org/review?bug=711412&attachment=258933)

> if (priv->rtx_delay == -1)
>   delay = (priv->avg_rtx_rtt / 2) * GST_MSECOND;
> else
>   delay = priv->rtx_delay * GST_MSECOND;

avg_rtx_rtt should be set to some reasonable default value until it has been
determined dynamically

Also, the delay should be calculated based on the observed interpacket arrival
jitter, which you
need to get from the session somehow.

>	 
>	  if (priv->rtx_retry_period == -1)
>	    calculated_period = priv->avg_rtx_rtt;
>	  else
>	    calculated_period = priv->avg_rtx_rtt;

that's not right (typo?) the retry period is either the rtx_retry_period or
based on the total jitterbuffer_size - avg_rtx_rtt or something like that

>	  if (priv->rtx_delay == -1)
>	    calculated_delay = priv->avg_rtx_rtt / 2;
>	  else
>	    calculated_delay = priv->rtx_delay;

again, must be based on interpacket arrival jitter.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.