[Bug 711664] Expose the transports list in the rtsp-stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711664
  GStreamer | gst-rtsp-server | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259243|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-11-11 17:52:46 UTC ---
Review of attachment 259243:
 --> (https://bugzilla.gnome.org/review?bug=711664&attachment=259243)

::: gst-rtsp-server/gst/rtsp-server/rtsp-stream.c
@@ +2005,3 @@
+ * @stream must be joined to a bin.
+ *
+ * Returns: A GstRTSPStreamTransport

Returning a GList is never really nice... but in any case this is missing
annotations for the element type: (element-type GstRTSPStreamTransport) and
about ownership (should probably be const, and (transfer none)).

However GstRTSPStream needs locking for access of this list, so you should
return a copy and also copy the elements. That would make it (transfer full)
then and not const. Otherwise this wouldn't be threadsafe at all.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.