[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259772|none                        |reviewed
             status|                            |

--- Comment #18 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-11-14 00:57:39 UTC ---
Review of attachment 259772:
 --> (https://bugzilla.gnome.org/review?bug=705991&attachment=259772)

::: gst/isomp4/qtdemux.c
@@ +1897,3 @@
+      }
+      g_array_free (qtdemux->cenc_protection_systems_info, TRUE);
+      qtdemux->cenc_protection_systems_info = NULL;

This whole block not so small and  is duplicated form the _dispose(), can you
make it into a function or something?

@@ +6175,3 @@
+
+      /* As an initial implementation, we simply choose the first
+       * available protection system. */

I'm a bit concerned that we're ignoring the case where there is more than one
PSSH box in the file. We should design something that works if we don't have a
decoder for the first PSSH, but only for the second. I think we should design
that in before we fix the caps.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.