[Bug 711094] videodecoder: improve max-error handling

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=711094
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
     Ever Confirmed|0                           |1

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-11-20 17:25:50 UTC ---
Looks fine to me,  but I have three nitpicks:

> +  if (dec->priv->max_errors >= 0 &&
> +      dec->priv->max_errors < dec->priv->error_count) {

While you're changing that section anyway, could you change the second line to

> +      dec->priv->error_count > dec->priv->max_errors) {

? I think that's more natural to read.

And I think it should it read 'was added _in_ 1.4' ?

> +      if (ret && priv->error_count && !priv->pushed_data) {

Please write that as .. && priv->error_count > 0 && ... - it's not a boolean.

(In reply to comment #3)
> About the second patch, what is the expected behavior when the stream goes EOS
> before receiving any data? Is this supposed to post an error too?

I would say no.

> Even if this is all because of segment clipping? Meaning that valid frames
> were decoded but falled out of the expected segment.

In that case definitely not, IMHO.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.