[Bug 712358] mssdemux: push language code tag

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Nov 28 16:51:10 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=712358
  GStreamer | gst-plugins-bad | unspecified

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #259864|none                        |needs-work
             status|                            |

--- Comment #4 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-11-29 00:51:03 UTC ---
Review of attachment 259864:
 --> (https://bugzilla.gnome.org/review?bug=712358&attachment=259864)

::: ext/smoothstreaming/gstmssdemux.c
@@ +1347,3 @@
     }

+    push_stream_tags (mssdemux, stream);

The tags should be pushed on the pad before the pad is exposed, that is before
called gst_element_add_pad(). This also applies to the segment. I'm not sure
why there is a pending_segments. So it should be pushed in
gst_mss_demux_expose_stream() I think.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list