[Bug 712343] riff: Make use of the various helper to handle video formats
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Thu Nov 28 17:04:34 PST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=712343
GStreamer | gst-plugins-base | unspecified
Olivier Crete (Tester) <olivier.crete> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #259844|none |needs-work
status| |
--- Comment #2 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2013-11-29 01:04:26 UTC ---
Review of attachment 259844:
--> (https://bugzilla.gnome.org/review?bug=712343&attachment=259844)
Looks good in general, except for:
::: gst-libs/gst/riff/riff-media.c
@@ +82,3 @@
+ break;
+ case 16:
+ format = GST_VIDEO_FORMAT_RGB16;
Are 15 and 16 valid here? I don't see them in the old code.
@@ +85,3 @@
+ break;
+ case 24:
+ format = GST_VIDEO_FORMAT_RGB;
This was BGR, not RGB
@@ +88,3 @@
+ break;
+ case 32:
+ format = GST_VIDEO_FORMAT_ARGB;
This should be BGRx, not ARGV
@@ -900,3 @@
caps = gst_caps_new_empty_simple ("video/x-fraps");
- if (codec_name)
- *codec_name = g_strdup ("Fraps video");
This isn't in pbutils, neither is x-xsub, we shoudl go over the entire list
first before we remove them. Either we should add it there or leave this here.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list