[Bug 719614] docs: add missing docs and fix errors

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Nov 30 10:13:16 PST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=719614
  GStreamer | gstreamer (core) | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #263210|none                        |reviewed
             status|                            |

--- Comment #4 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2013-11-30 18:13:11 UTC ---
Review of attachment 263210:
 --> (https://bugzilla.gnome.org/review?bug=719614&attachment=263210)

Typo in comment, GstOutputSelectorPad*Negoriation*Mode

::: docs/libs/gstreamer-libs-sections.txt
@@ +85,2 @@
 <SECTION>
+<FILE>gstindex</FILE>

I'm not sure if we should make this visible. Also, many are inside #if 0 #endif
block, looks like GTK Doc does not detect it.

Commented out:

_new
_comit
_get_group
_new_group
_set_group
_set_certainty
_get_certainty
_set_filter
_set_filter_full
_set_resolver
_set_resolver_full
_add_format
_add_association
_add_object

::: docs/plugins/gstreamer-plugins-sections.txt
@@ +172,3 @@
 GST_IS_QUEUE
 GST_QUEUE_CLASS
+GST_QUEUE_CAST

Maybe we could just put a skip on this one, after-all it's kind of legacy ?

::: gst/gstcontrolsource.c
@@ +26,3 @@
  *
  * The #GstControlSource is a base class for control value sources that could
+ * be used on an object to get timestamp-value pairs. A control source

could be use <> to get ? Why do we need an object ?

::: gst/gstobject.c
@@ +1137,3 @@
  * or not.
  *
+ * This function is used to disable the controller on a property for

to disable the *control bindings* on a property ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list