[Bug 708921] pbutils: Add codec-utility functions to support h265
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Oct 1 23:25:29 CEST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=708921
GStreamer | gst-plugins-base | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #255925|none |needs-work
status| |
--- Comment #1 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-01 21:25:24 UTC ---
Review of attachment 255925:
--> (https://bugzilla.gnome.org/review?bug=708921&attachment=255925)
Please also add this to the documentation, and win32/common/*.def.
::: gst-libs/gst/pbutils/codec-utils.c
@@ +4,3 @@
* 2010 Collabora Multimedia
* 2010 Nokia Corporation
+ * 2013 Intel Corporation
Please indent this properly, tabs and spaces mixed it seems
@@ +725,3 @@
+ tier = "High";
+ else
+ tier = "Main";
This should maybe be lower-case for consistency too
::: gst-libs/gst/pbutils/codec-utils.h
@@ +64,3 @@
+gboolean gst_codec_utils_h265_caps_set_level_tier_and_profile (GstCaps
* caps,
+ const
guint8 * profile_tier_level,
+ guint
len);
Please indent all functions in the h265 section properly... let the opening (
be in the same column for all of them, and one parameter per line for the first
three functions too.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list