[Bug 709180] mpegts: [PATCH] [FIXME] Return GstMpegTsDescriptor in mpegts_get_descriptor_from_*

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709180
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2013-10-02 05:43:20 UTC ---
The part in mpegtsbase.[ch] is fine.

The usage is a bit more tricky. *Ideally* we should be using mpeg-ts-lib
functions, but the one for languages is a bit heavy and we don't have one for
ac3 descriptor.

For language, maybe we could have a one-shot variant:

gboolean
gst_mpegts_descriptor_parse_iso_639_language_idx
   (const GstMpegTsDescriptor *descriptor,
    guint idx, gchar *lang[4],
    GstMpegTsIso639AudioType *audio_type);

idx: index in the table (if you ask for something bigger than the size of the
descriptor the method returns FALSE and you can stop iterating)
lang: output for the language code (NULL-terminated) for that index
audio_type: output for the audio_type for that index

This would allow doing
  while (gst_mpegts_descriptor_parse_iso_639_language_idx(desc, i, &lang,
&type))
   {
      // do something
      i++;
   }


For the AC3 one I'm not 100% sure what the method should look like (The
description of that descriptor is in ATSC A/52 specifications btw).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.