[Bug 706211] applemedia: Garbled output from vtenc_h264

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Oct 2 10:01:37 CEST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=706211
  GStreamer | gst-plugins-bad | 1.1.3

Ole André Vadla Ravnås <oleavr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256231|none                        |needs-work
             status|                            |

--- Comment #7 from Ole André Vadla Ravnås <oleavr at soundrop.com> 2013-10-02 08:01:34 UTC ---
Review of attachment 256231:
 --> (https://bugzilla.gnome.org/review?bug=706211&attachment=256231)

Looks great! Just one nitpick from me. For consistency:

+
+
+      for (unsigned i = 0; i < num_planes; ++i) {

Should be:

+
+      for (size_t i = 0; i != num_planes; i++) {

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list