[Bug 706211] applemedia: Garbled output from vtenc_h264

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706211
  GStreamer | gst-plugins-bad | 1.1.3

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256240|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-02 09:29:42 UTC ---
Review of attachment 256240:
 --> (https://bugzilla.gnome.org/review?bug=706211&attachment=256240)

::: sys/applemedia/vtenc.c
@@ +781,3 @@
     CVReturn cv_ret;

+    frame = gst_vtenc_frame_new (buf, &self->video_info);

Should check for NULL here, you made it possible for the function to fail

@@ +790,3 @@
+      size_t plane_bytes_per_row[num_planes];
+
+      for (size_t i = 0; i != num_planes; i++) {

Why != instead of < ?

@@ +797,3 @@
+        plane_bytes_per_row[i] =
+            GST_VIDEO_FRAME_COMP_STRIDE (&frame->videoframe, i);
+        plane_bytes_per_row[1] =

should be [i], not [1] I guess

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.