[Bug 709408] audioconvert: modifies buffer mapped for READ

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709408
  GStreamer | gst-plugins-base | git

--- Comment #3 from Matej Knopp <matej.knopp at gmail.com> 2013-10-04 11:04:05 UTC ---
gboolean
audio_convert_convert (AudioConvertCtx * ctx, gpointer src,
    gpointer dst, gint samples, gboolean src_writable)

later src is used as tmpbuf

if ((insize >= biggest) && src_writable && (ctx->in.bpf >= size))
    tmpbuf = src;

it looks like just a way to avoid creating temporary buffer. 

Thinking of it, perhaps src_writable should only be set if buffer is writable
and the memory is writable, otherwise it just copies the entire memory instead
of creating temporary buffer.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.