[Bug 700505] Video corruption when dashdemux changes bitrate

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=700505
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247193|none                        |reviewed
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-07 09:14:11 UTC ---
Review of attachment 247193:
 --> (https://bugzilla.gnome.org/review?bug=700505&attachment=247193)

::: gst/isomp4/qtdemux.c
@@ +4615,3 @@
                 QtDemuxStream *stream = demux->streams[n];

+                gst_qtdemux_configure_stream (demux, stream,
send_stream_start);

So this here is the only place where no new stream-start is sent sometimes. Why
exactly, what does it break how?

@@ +5632,3 @@
         GST_ELEMENT_CAST (qtdemux), "%03u", stream->track_id);
+    if (send_stream_start)
+      gst_pad_push_event (stream->pad, gst_event_new_stream_start
(stream_id));

While looking at this... dashdemux should set the same group-id on the
stream-start events of all streams that belong together. And when a new group
starts set a new group-id on all of them.

(A group means here the set of streams that should be played together)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.