[Bug 658309] [souphttpsrc] how to seek?=?UTF-8?Q?=20If=20the=20server=20uses=20=E2=80=9Cchunked=20encoding=E2=80=9D?=?

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=658309
  GStreamer | gst-plugins-good | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255132|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-07 13:59:29 UTC ---
Review of attachment 255132:
 --> (https://bugzilla.gnome.org/review?bug=658309&attachment=255132)

Don't use // comments

::: ext/soup/gstsouphttpsrc.c
@@ +1432,3 @@
+
+static void
+gst_soup_http_src_determine_size (GstSoupHTTPSrc * src)

Maybe the content-length handling should be moved in here too

@@ +1457,3 @@
+
+      // Parse out size from string in format:
+      //   TimeSeekRange.dlna.org: npt=0:00:00.000-0:04:58.783/0:04:58.783
bytes=0-31683075/31683076

You could just use something like sscanf() here. Would also be good to do
something with the time values here :)

@@ +1463,3 @@
+      for (i = 0; value[i]; i++) {
+        value[i] = toupper (value[i]);
+      }

There's a glib function to convert a complete string to upper case.
g_str_toupper() or g_strup() or something like that... but can't you just use
sscanf() on that without converting to uppercase?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.