[Bug 699077] videorate: Add a property to modify clip speed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699077
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255125|none                        |needs-work
             status|                            |

--- Comment #31 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-07 14:08:02 UTC ---
Review of attachment 255125:
 --> (https://bugzilla.gnome.org/review?bug=699077&attachment=255125)

Generally looks good but the following. Forbid rate changes during states >
READY maybe

::: gst/videorate/gstvideorate.c
@@ +747,3 @@
+      if (GST_CLOCK_TIME_IS_VALID (segment.stop))
+        segment.stop = (gint64) (segment.stop / videorate->rate);
+      segment.time = (gint64) (segment.time / videorate->rate);

These calculations assume that the rate was always the same before, and also
will never change in the future

@@ +955,3 @@
+          duration);
+      if (GST_CLOCK_TIME_IS_VALID (duration)) {
+        duration = (gint64) (duration / videorate->rate);

Same here

@@ +975,3 @@
+      dst_value =
+          (gint64) (gst_segment_to_stream_time (&videorate->segment,
+              GST_FORMAT_TIME, videorate->last_ts / videorate->rate));

and here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.