[Bug 709588] encodebin: Handle changes in encoding_profile::restriction during playback

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709588
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256652|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-08 10:16:14 UTC ---
Review of attachment 256652:
 --> (https://bugzilla.gnome.org/review?bug=709588&attachment=256652)

Looks good in general but:

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +223,3 @@
+        caps = gst_caps_copy (prof->restriction);
+
+      gst_value_set_caps (value, caps);

Why copy the caps? Why not just gst_value_set_caps (value, prof->restriction)?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.