[Bug 709414] dvbsrc: Uses deprecated field frontend type

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed Oct 9 18:17:53 CEST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=709414
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256796|none                        |reviewed
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-09 16:17:52 UTC ---
Review of attachment 256796:
 --> (https://bugzilla.gnome.org/review?bug=709414&attachment=256796)

Looks good to me, needs to be tested by someone with DVB (Edward? :) )

::: sys/dvb/gstdvbsrc.c
@@ +875,3 @@
+      G_TYPE_BOOLEAN, fe_info.caps & FE_CAN_GUARD_INTERVAL_AUTO,
+      "auto-hierarchy", G_TYPE_BOOLEAN, fe_info.caps % FE_CAN_HIERARCHY_AUTO,
+      "auto-fec", G_TYPE_BOOLEAN, fe_info.caps & FE_CAN_FEC_AUTO, NULL);

You now set these auto-* fields always. Previously they were only set depending
on the delsys. Does this make sense?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list