[Bug 709754] New: gst_audio_ring_buffer_set_channel_positions() clears need_reorder flag wrongly

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709754
  GStreamer | gst-plugins-base | 1.2.0

           Summary: gst_audio_ring_buffer_set_channel_positions() clears
                    need_reorder flag wrongly
    Classification: Platform
           Product: GStreamer
           Version: 1.2.0
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: tiwai at suse.de
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=256836)
 View: https://bugzilla.gnome.org/attachment.cgi?id=256836
 Review: https://bugzilla.gnome.org/review?bug=709754&attachment=256836

Fix patch

gst_audio_ring_buffer_set_channel_positions() checks whether the given
positions are identical with the current setup and returns
immediately if so.  But it also clears need_reorder flag before this
comparison, thus this flag might be wrongly cleared if the function is
called twice with the same channel positions.

The fix patch is attached below.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.