[Bug 709414] dvbsrc: Uses deprecated field frontend type

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709414
  GStreamer | gst-plugins-bad | git

--- Comment #13 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-10-10 11:26:01 UTC ---
(In reply to comment #11)
> (In reply to comment #9)
> > Review of attachment 256796 [details] [details]:
> > 
> > Looks good to me, needs to be tested by someone with DVB (Edward? :) )
> > 
> > ::: sys/dvb/gstdvbsrc.c
> > @@ +875,3 @@
> > +      G_TYPE_BOOLEAN, fe_info.caps & FE_CAN_GUARD_INTERVAL_AUTO,
> > +      "auto-hierarchy", G_TYPE_BOOLEAN, fe_info.caps % FE_CAN_HIERARCHY_AUTO,
> > +      "auto-fec", G_TYPE_BOOLEAN, fe_info.caps & FE_CAN_FEC_AUTO, NULL);
> > 
> > You now set these auto-* fields always. Previously they were only set depending
> > on the delsys. Does this make sense?
> 
> I don't know it for all delsys. Can I add the same fields?

Thinking about it, it should be fine as is.

(In reply to comment #12)
> (In reply to comment #10)
> > Review of attachment 256797 [details] [details]:
> > 
> > Looks generally good to me
> > 
> > ::: sys/dvb/gstdvbsrc.c
> > @@ +555,3 @@
> > +      g_param_spec_int ("stream-id", "stream-id",
> > +          "Stream ID (DVB-T2 and DVB-S2 max 255, ISDB max 65535)",
> > +          -1, 65535, DEFAULT_STREAM_ID, G_PARAM_READWRITE));
> > 
> > What's -1? Add that to the description :)
> 
> -1 = disabled and is default.

ok, just add that then :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.