[Bug 709747] [wayland_egl] Add support for GstVideoOverlay

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709747
  GStreamer | gst-plugins-gl | git

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> 2013-10-10 14:50:38 UTC ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> So for Wayland there is a EGLDisplay and a separate wl_display? Ugly :/ I think
> this should somehow be made more clear then in the API, and more strict
> distinction between the EGLDisplay-like things and the wl_display.

Not sure to follow you because a EGLDisplay is made from NativeDisplayType, see
eglGetDisplay
(http://www.khronos.org/registry/egl/sdk/docs/man/xhtml/eglGetDisplay.html)
so when using egl there is always a EGLDisplay and a separate native display.


To resume the handle returned by "gst_gl_window_get_display" is always the
native display, either on egl, glx, wgl etc. (note that there is no glwayland,
only egl)

Currently I can see that this is GstGLContext that own the EGLDisplay. (Note
that the only way to retrieve the EGLDisplay from GstGLDisplay is to do
GST_GL_CONTEXT_EGL (gst_gl_context_get_gl_context (context))->egl_display. 
Also eglGetDisplay is called in "gst_gl_context_egl_create_context".

So actually for egl we need a way to let the application know "its native
display instance" to our gstegl engine. I choosed to use a a property on
glimagesink but maybe a better solution would be to add
GstVideoOverlay::gst_video_overlay_set_display_handle  ?

Well then the thing is how to transmit this native display handle from
glimagesink to the GstGLWindow, before the context calls GstGLWindow::open.

Actually I did not realize that this is the same question for the window handle
:) (gst_gl_window_set_window_handle) 
So I'm going to create a gst_gl_window_set_display_handle (as there is a
gst_gl_window_get_display which one should be renamed to
gst_gl_window_get_display_handle)

When not using egl, gst_gl_window_set_display_handle would just be empty.

That will allow to remove the confusing "gst_gl_display_new_with_platform".

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.