[Bug 703518] Qt5/QtQuick 2.0 video element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703518
  GStreamer | qt-gstreamer | unspecified

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kiagiadakis.george at gmail.co
                   |                            |m

--- Comment #13 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2013-10-11 13:27:38 UTC ---
So, let me do some generic comments first and then go into detail on each
patch. 

In general, the approach is correct. I believe, though, that it could be shaped
better. First, the VideoNode* classes are in the wrong place. They should be
part of the element plugin imho and not part of the public API library. This
would also remove the dependency that is introduced in this patch which makes
qtvideosink link to QtGStreamerUi. The general design that was followed in the
making of qtvideosink was to avoid using any QtGStreamer API, so that it can be
used independently. Also, the VideoNode* classes share GL code & shaders with
qtglvideosink. It would be nice if the code is actually shared instead of
copied.

Second, avoiding any qml2-related code in QtGStreamerUi would be better, as
this library links with QtWidgets and there may be people wanting to use only
Qt Quick and avoid distributing QtWidgets. For this, I would consider a new
QtGStreamerQuick library.

Third, the BasicMediaPlayer item... I'm not sure about it. I know this is
perhaps useful for examples and tests, but I don't think this is what
QtGStreamer is for. QtMultimedia and phonon also use playbin2 to do the same
thing. If people just want a playbin pipeline, why not just use those APIs
instead?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.