[Bug 703518] Qt5/QtQuick 2.0 video element

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=703518
  GStreamer | qt-gstreamer | unspecified

George Kiagiadakis <kiagiadakis.george> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248291|none                        |needs-work
             status|                            |

--- Comment #17 from George Kiagiadakis <kiagiadakis.george at gmail.com> 2013-10-11 14:29:38 UTC ---
Review of attachment 248291:
 --> (https://bugzilla.gnome.org/review?bug=703518&attachment=248291)

The qml2 plugin export mechanism confuses me a bit, there are a lot of names
involved... We have QtGStreamerQuick2.json,
org.freedesktop.gstreamer.Qt5GStreamerQuick2-0.10, QtGStreamerQuick2 in the
qmldir file, and in the example (later patch) it is loaded with "import
QtGStreamer.Quick2 0.10". That is just confusing. I'd expect one name
everywhere (Qt5GStreamerQuick2 ?).

Also note that this patch should also modify the UNINSTALLED_IMPORTS_DIR in the
qmlplayer example, as the directory is changing with this patch.

::: qt-gstreamer-orig/src/qml/quick2/CMakeLists.txt
@@ +13,3 @@
+  # On windows with gcc, cmake calls the binary libFOO.dll, but the Qt plugin
loader
+  # does not remove the lib prefix when searching for .dlls, unlike what
happens on unix
+  file(WRITE ${CMAKE_CURRENT_BINARY_DIR}/qmldir "plugin libQtGStreamerQuick2")

Apparently qmldir nowdays also requires a "module Foo" statement, otherwise it
shows a warning.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.