[Bug 709826] mpegtsmux: performance issue

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709826
  GStreamer | gst-plugins-bad | git

--- Comment #5 from Jesper Larsen <jesper.larsen at ixonos.com> 2013-10-14 06:44:54 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> 
> > 
> > Meanwhile, looking at the callgrind output brought my attention to how stuffing
> > bytes are written.
> > 
> > This patch uses memset to set all stuffing bytes to 0xFF instead of using a
> > loop to set them byte-by-byte.
> 
>   That patch is correct ... but you'll notice that function you optimized
> doesn't even appear in the callgrind graph, so it's negligeable :)

I won't argue with that. ;)

It appeared in my callgrind graph (about 5%) because I accidental used buffers
without timestamps. This made the muxer write a PMT/PAT for every buffer,
meaning a lot of stuffing bytes.

So in a situation where you write a stream containing a substantial amount of
stuffing bytes the difference is no longer negligible.

Anyway, I thought it was silly to just ignore the optimization however small it
is, when the readability of the code is not affected (IMO).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.