[Bug 710078] rtspserver test: "racy" behavior in get_unused_port function
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Oct 15 09:22:06 CEST 2013
https://bugzilla.gnome.org/show_bug.cgi?id=710078
GStreamer | gst-rtsp-server | unspecified
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #257321|none |needs-work
status| |
--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-15 07:21:58 UTC ---
Review of attachment 257321:
--> (https://bugzilla.gnome.org/review?bug=710078&attachment=257321)
::: gst/rtsp-server/rtsp-server.c
@@ +856,3 @@
+ sock = g_socket_get_fd (socket);
+
+ if (getsockname (sock, (struct sockaddr *) &native_addr, &addr_len)
== 0) {
Oh sorry, also use g_inet_socket_address_get_port() for portability please. The
above most likely does not work properly on Windows.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list