[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

--- Comment #19 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-10-25 22:11:43 UTC ---
(In reply to comment #18)
> This looks a bit weird, esp. how it's used in oggdemux, but can't quite put my
> finger on what exactly right now. Will have another look tomorrow.

Using a struct with an integer inside might make it more clear. Also an
int-based function can be provided if that is easier, but I guess it doesn't
add much.

The other option I see is to create some kind of GstPadFlowCombiner with an API
like:

* gst_pad_flow_combiner_set_pad_flow_return (combiner, pad, flow_ret)
* gst_pad_flow_combiner_get_combined_flow_return (combiner)

The advantage of this is that you only update the flow of the pad you pushed
and you can get a small performance improvement, but then most scenarios only
have a few pads and it shouldn't matter much. It adds more to the core side,
and makes it easier to use on demuxers.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.