[Bug 707534] BufferPool don't buffer GstMemory in 1.x

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Oct 26 11:25:08 CEST 2013


https://bugzilla.gnome.org/show_bug.cgi?id=707534
  GStreamer | gstreamer (core) | git

--- Comment #3 from Michael Olbrich <m.olbrich at pengutronix.de> 2013-10-26 09:25:01 UTC ---
The code to hook in returning memory to the pool is rather ugly. Can't we 
create a GstPoolMemory class that handles that and then use that class in all
memory implementations? As far as I can tell the GstMemory subclasses are all
private API so that should be possible.

The stuff with draining is orthogonal to the memory change, right? This makes 
sence with buffers as well, right?

Abuout the v4l2 stuff:
Can you please split the first patch? It does a lot of things at once. That 
makes it hard to review.
Why is gst_allocator_wait_for_empty() needed here?
gst_v4l2_buffer_pool_free_buffers() is olny called after all buffers are back 
in the pool.  The same should be true for memorys.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list