[Bug 671136] mpegtsmux: add support for SDT and NIT tables for DVB-S/DVB-T

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=671136
  GStreamer | gst-plugins-bad | git

--- Comment #10 from Edward Hervey <bilboed at bilboed.com> 2013-10-28 10:49:22 UTC ---
(In reply to comment #9)
> > How will we handle multiple sections ?
> 
> Excellent question. This seems to be something that should be handled outside
> the library?
> 
> With the addition of the section_packetizer I guess there is the possibility of
> making the user responsible of updating the public
> section_number/last_section_number fields in the GstMpegTsSection?

  Or we could accept sections bigger than the limit (1024) and automatically
create multiple sections (with the (last_)section_number fields correctly set)
? But then it would break the 1:1 relationship between parsed stuff and
sections.

> 
> > 
> > ::: gst-libs/gst/mpegts/gstmpegtssection.c
> > @@ +795,3 @@
> > +
> > +/**
> > + * gst_mpegts_section_packetize:
> > 
> > _private_section_packetize ?
> 
> This function needs to be public for use in i.e. muxer?

Sorry I thought it was the support for private sections (i.e. undefined type).

malloc-ing and memcpy-ing once again seems overkill.

We should just create the final entire section once. So maybe we do need to
delay the packetization of the section-specific data to that point in time.

Store a packetize vfunc in GstMpegTSSection and use that one when we really
need the fully packetized value ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.