[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258608|none                        |needs-work
             status|                            |

--- Comment #23 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-30 19:57:42 UTC ---
Review of attachment 258608:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=258608)

::: gst/gstutils.c
@@ +3889,3 @@
+gst_flow_return_combiner_new (void)
+{
+  GstFlowReturnCombiner *combiner = g_new0 (GstFlowReturnCombiner, 1);

g_slice_new0()

@@ +3952,3 @@
+
+GstFlowReturn
+gst_flow_return_combiner_get_flow_return (GstFlowReturnCombiner * combiner)

Instead I would propose
GstFlowReturn gst_flow_return_combiner_get_flow_return (GstFlowReturnCombiner
*c, GstPad *pad, GstFlowReturn ret)

This should return ret immediately for errors instead of combining anything

@@ +3993,3 @@
+
+void
+gst_flow_return_combiner_set_flow_return (GstFlowReturnCombiner * combiner,

Docs missing everywhere ;) And make sure to say that this is not threadsafe and
the caller has to ensure that

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.