[Bug 699924] smoothstreaming: no audio with BBC bigbuckbunny stream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699924
  GStreamer | gst-plugins-bad | git

--- Comment #15 from Antonio Ospite <ospite at studenti.unina.it> 2013-10-31 10:15:32 UTC ---
(In reply to comment #14)
> Review of attachment 257428 [details]:
> 
> ::: ext/smoothstreaming/gstmssmanifest.c
> @@ +612,3 @@
> +
> +        if (mapinfo.size >= 16) {
> +          gint cbSize = GST_READ_UINT16_LE (mapinfo.data + 16);
> 
> You need to check that it's >= 18 if you want to read 2 bytes at offset 16
>

Of course, thanks, I spotted this just after I had sent out the patch :)

> @@ +613,3 @@
> +        if (mapinfo.size >= 16) {
> +          gint cbSize = GST_READ_UINT16_LE (mapinfo.data + 16);
> +          fprintf (stderr, "%s cbSize: %d\n", __func__, cbSize);
> 
> You can use GST_DEBUG() here
>

I will, thanks, I am still learning about the infrastructure.

> @@ +619,3 @@
> +             * whole "WaveFormatEx" */
> +            gst_buffer_resize (codec_data, 18, -1);
> +            goto endif;
> 
> Best would be without a goto here :) Also won't you still pass the complete
> struct as codec_data in all other cases?

I want to check with the Microsoft smooth streaming specification before
sending an update, chances are that the code can just be simplified: if the wav
header is _always_ supposed to be a WAVEFORMATEX (at least 18 bytes), than I'll
always consume these 18 bytes and just pass the rest to the decoder in
codec_data.

Regards,
   Antonio

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.