[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #258630|none                        |needs-work
             status|                            |

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-31 13:59:09 UTC ---
Review of attachment 258630:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=258630)

Looks good except for some nitpicks :)

::: gst/gstutils.c
@@ +3801,3 @@
+ * GstFlowCombiner:
+ *
+ * Utilitary struct to help handling #GstFlowReturn combination. Useful for

Is utilitary the right word here? Utility struct maybe?

@@ +3853,3 @@
+  GstFlowCombiner *combiner = g_slice_new (GstFlowCombiner);
+
+  combiner->table = g_hash_table_new (g_direct_hash, NULL);

g_direct_equal() ?

@@ +3993,3 @@
+gst_flow_combiner_update_flow_return (GstFlowCombiner * combiner, GstPad *
pad,
+    GstFlowReturn fret)
+{

Add some g_return_val_if_fail() here and in other public functions

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.