[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

--- Comment #27 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2013-10-31 16:47:56 UTC ---
Review of attachment 258630:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=258630)

Some gram fixes

::: gst/gstutils.c
@@ +3806,3 @@
+ *
+ * #GstFlowCombiner works by storing the #GstFlowReturn for a given #GstPad
+ * and when a #GstFlowReturn is stored it computes the combined return value

once a #GstFlowReturn maybe?

is stored,

@@ +3813,3 @@
+ * Whenever the #GstFlowReturn for a pad needs to be updated, call
+ * gst_flow_combiner_update_flow_return(), this function already returns
+ * the new combined #GstFlowReturn for the current #GstPad<!-- -->s in it.

already returns/will return? Not entirely sure about this one though. Maybe
I'm not getting this sentence's meaning right

@@ +3818,3 @@
+ *
+ * Please be aware that this struct isn't thread safe as its major use case
+ * is for demuxers, that usually will have a single thread operating it.

as it's designed to be used by demuxers. These will likely have just one thread
operating on them

You might want to go with another rephrasing alternative though. The idea is
that demuxers are not an 'use cases' per se but 'users'.

@@ +3826,3 @@
+ * Aside from reducing the user's code size, the main advantage of using this
+ * helper struct is to follow the standard rules for #GstFlowReturn
combination,
+ * those rules are:

combination. These rules are:

@@ +3862,3 @@
+ * @combiner: the #GstFlowCombiner to clear
+ *
+ * Resets a #GstFlowCombiner to its initial states, without any #GstPad<!--
-->s

initial state

@@ +4023,3 @@
+ * @pad: (transfer-none): the #GstPad to remove
+ *
+ * Removes a #GstPad to the #GstFlowCombiner. Its flow return is also

Removes a #GstPad from the

@@ +4024,3 @@
+ *
+ * Removes a #GstPad to the #GstFlowCombiner. Its flow return is also
+ * removed and not used for future combinations.

Are there any chances of using it if it has been removed? Seems redundant

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.