[Bug 687183] playbin: caps negotation if VIDEO_FORMAT is unknown

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=687183
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #257412|none                        |needs-work
             status|                            |

--- Comment #48 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2013-10-31 20:56:07 UTC ---
Review of attachment 257412:
 --> (https://bugzilla.gnome.org/review?bug=687183&attachment=257412)

::: gst-libs/gst/video/gstvideodecoder.c
@@ +2941,3 @@
   gst_video_info_init (&vinfo);
+  if (outcaps)
+    gst_video_info_from_caps (&vinfo, outcaps);

The vinfo is probably used some lines below, not sure if the default values in
there make sense or something else should be done instead

@@ +3198,3 @@
   GST_VIDEO_DECODER_STREAM_LOCK (decoder);
+  if (G_UNLIKELY (!decoder->priv->output_state
+          || decoder->priv->output_state_changed

How can you even allocate a buffer without knowing the output format? I think
this looks wrong. Negotiation shouldn't be allowed to be triggered from buffer
allocation if the output format is not known yet, it should be triggered
elsewhere.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.