[Bug 706719] Quote autogen.sh arguments when passing to autogen_options

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706719
  GStreamer | common | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253092|none                        |reviewed
             status|                            |

--- Comment #12 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2013-09-03 14:50:08 UTC ---
(From update of attachment 253092)
>+test ! -z "$CONFIGURE_DEF_OPT" && echo "  default flags:  ${CONFIGURE_DEF_OPT//$nl/ }"
>+test ! -z "$CONFIGURE_EXT_OPT" && echo "  external flags: ${CONFIGURE_EXT_OPT//$nl/ }"

Isn't this substitution a bash-ism?

If I use it in a script with #/bin/sh I get 'Bad substitution' (from /bin/sh ->
dash)
>
>+IFS="$nl"
> "$srcdir/configure" $CONFIGURE_DEF_OPT $CONFIGURE_EXT_OPT || {
>         echo "  configure failed"
>         exit 1
> }
>+unset IFS

The IFS change does not affect the configure script, does it? Because it's run
as a separate executable and not just included?

Is separating the DEF_OPT and EXT_OPT with a space in order here when passing
the args to configure, or should it be a newline as well?

Sorry if these are noobish questions.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.