[Bug 707340] qtmux: should NOT use PTS if DTS is missing

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Sep 3 10:59:57 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=707340
  GStreamer | gst-plugins-good | git

--- Comment #8 from Matej Knopp <matej.knopp at gmail.com> 2013-09-03 17:59:51 UTC ---
Created an attachment (id=254006)
 View: https://bugzilla.gnome.org/attachment.cgi?id=254006
 Review: https://bugzilla.gnome.org/review?bug=707340&attachment=254006

Patch

This patch does couple o things:

1 When DTS is missing on buffer, it uses either segment start or last buffer
end time, which ever is bigger. I think this should produce best results even
for cases like segment in mid stream where first few DTS are set to -1 because
they are before segment start

2 It sets first_ts to DTS for streams that have DTS. Right now it is always set
to first buffer PTS, which doesn't seem to make much sense since DTS is used
for durations in such streams.

3 it makes sure duration is a valid number for last buffer (otherwise
GST_CLOCK_TIME_NONE is used in calculations for last sample, which doesn't
produce good results) :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list