[Bug 696437] qtmux: add support for mp4 timed text

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=696437
  GStreamer | gst-plugins-good | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #254922|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-16 08:56:40 UTC ---
Review of attachment 254922:
 --> (https://bugzilla.gnome.org/review?bug=696437&attachment=254922)

::: gst/isomp4/gstqtmux.c
@@ +272,3 @@
   }

+  if (params->subtitle_sink_caps) {

Shouldn't you check for non-empty caps here? You use GST_STATIC_CAPS_NONE below

@@ +575,3 @@
+
+  gst_buffer_map (buf, &map_old, GST_MAP_READ);
+  size = (gint16) _strnlen ((const char *) map_old.data, map_old.size);

Why don't you just use strnlen() here?

@@ +2521,3 @@
+    GST_BUFFER_PTS (res) = time_span_min;
+    GST_BUFFER_DURATION (res) = time_span_max - time_span_min;
+    g_string_free (string, TRUE);

You could just reuse the GString memory here and use gst_memory_new_wrapped()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.