[Bug 707975] qtdemux: Can't handle datetimes before 1970 yet

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=707975
  GStreamer | gst-plugins-good | unspecified

--- Comment #2 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-09-16 14:47:35 UTC ---
Created an attachment (id=255034)
 View: https://bugzilla.gnome.org/attachment.cgi?id=255034
 Review: https://bugzilla.gnome.org/review?bug=707975&attachment=255034

qtdemux: add code to parse creation time earlier than 1970

Use g_date_time seconds manipulation to allow to cover the quicktime
spec for creation_time. It uses seconds since 1904.

Both paths could be done using the generic approach of seconds since
1904 with GDateTime handling, but the first path using seconds from
1970 should be more commonly found and avoids a few objects creation and
ref/unref, so keep it there for performance.

Additionally, the code for handling seconds since 1970 changed from >
to >= because having 0 seconds since 1970 is also a valid case for that
path to handle.

----
This particular sample has a creation_time of 1970-01-01 00:00:00, so it
could be handled directly by simply changing the > for a >= in the
creation_time sanity check. However, as we visit this code, let's fix it for
once and add 'seconds since 1904' handling.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.