[Bug 708416] Implement flushing seek support in collectpads

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Sep 19 15:03:45 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=708416
  GStreamer | gstreamer (core) | git

--- Comment #6 from Alessandro Decina <alessandro.d at gmail.com> 2013-09-19 22:03:41 UTC ---
I did(In reply to comment #5)
> Review of attachment 255352 [details]:
> 
> There is a wrong update of common/ in there.

oops


> ::: libs/gst/base/gstcollectpads.c
> @@ +1199,3 @@
>    if (!GST_COLLECT_PADS_STATE_IS_SET (data, GST_COLLECT_PADS_STATE_LOCKED) &&
>        (GST_COLLECT_PADS_STATE_IS_SET (data, GST_COLLECT_PADS_STATE_WAITING) !=
> +          !!waiting)) {
> 
> Did you run it through gst-indent? It does produce this horror

I did. I can take the change out but is ! !waiting better than !!waiting?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list