[Bug 706083] v4l2src: UVC Allocated buffers wrapped in GstBuffer get orphaned by GstBuffer API
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Sep 21 00:31:32 PDT 2013
https://bugzilla.gnome.org/show_bug.cgi?id=706083
GStreamer | gst-plugins-good | git
Sebastian Dröge (slomo) <slomo> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #255355|none |reviewed
status| |
--- Comment #34 from Sebastian Dröge (slomo) <slomo at circular-chaos.org> 2013-09-21 07:31:24 UTC ---
Review of attachment 255355:
--> (https://bugzilla.gnome.org/review?bug=706083&attachment=255355)
Looks good in general to me, please push after Robert has tested it and:
::: sys/v4l2/gstv4l2bufferpool.c
@@ +897,3 @@
+ /* copy the buffer */
+ copy = gst_buffer_copy_region (*buffer,
+ GST_BUFFER_COPY_ALL | GST_BUFFER_COPY_DEEP, 0, -1);
Why are you doing a deep copy here? Please add at least a comment :)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list