[Bug 708633] Adder should not take channel mask in consideration when in mono or stereo.

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708633
  GStreamer | gst-plugins-base | git

Mathieu Duponchelle <mathieu.duponchelle> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255577|0                           |1
        is obsolete|                            |
             Status|NEW                         |ASSIGNED
         AssignedTo|gstreamer-bugs at lists.freede |mathieu.duponchelle at epitech
                   |sktop.org                   |.eu

--- Comment #3 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2013-09-23 15:47:12 UTC ---
Created an attachment (id=255582)
 View: https://bugzilla.gnome.org/attachment.cgi?id=255582
 Review: https://bugzilla.gnome.org/review?bug=708633&attachment=255582

Review fixes.

> This could be a range or list, not necessarily an int

I think if it's a range we can assume channel-mask should either not be set or
not matter here ?

> In setcaps the size should always be 1, no?

True, fixed

> And here it should be always an int

OK, but may'be it's still better to check in case it hasn't been set at all ? I
know channels is mandatory but some elements might not respect it ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.