[Bug 708688] Message EISS and SCTE signaling sections on bus similar to PSI

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708688
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255640|none                        |needs-work
             status|                            |

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2013-09-25 06:20:39 UTC ---
Review of attachment 255640:
 --> (https://bugzilla.gnome.org/review?bug=708688&attachment=255640)

::: gst-libs/gst/mpegts/gstmpegtssection.h
@@ +97,3 @@
   GST_MTS_TABLE_ID_DSM_CC_ADDRESSABLE_SECTIONS        = 0x3F,

+  /* SCTE-35 / CL-SP-ETV-AM 1.0.1 */

This should go in a new header file (like it's done for the dvb and atsc
sections).

gst-scte-section.h maybe ?

And add documentation about them :)

@@ +307,2 @@
   /* 0x80 - 0xff : User Private (or defined in other specs) */
+  GST_MPEG_TS_STREAM_TYPE_SIGNALING                    = 0xC0,

Only ISO/IEC 13818-1 / ITU H.222.0 stuff should go here.

Create a new enum in gst-scte-section.h

Bonus points and free beers are offered if you put the full list of stream
types defined by SCTE :)

::: gst/mpegtsdemux/mpegtsbase.c
@@ +649,3 @@
+                  stream->pid, SAFE_FOURCC_ARGS (program->registration_id));
+
+              if ((DRF_ID_ETV1 == program->registration_id) ||

no yoda coding please.

Also, shouldn't you be checking ... the *stream* registration_id ? I thought it
wasn't guaranteed that the program would have the ETV1/CUEI registration id.

Maybe a simple macro would help clarify the code also

::: tests/examples/mpegts/ts-parser.c
@@ +375,3 @@
 }

+// TODO: add dump_signaling()

Maybe we can leave these ts-parser changes aside for the time being.

It would be better if we created a new GstMpegTsSectionType for those.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.