[Bug 680087] flvdemux: seek in push mode makes it start from beginning

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=680087
  GStreamer | gst-plugins-good | 1.x

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255793|none                        |needs-work
             status|                            |

--- Comment #13 from Edward Hervey <bilboed at bilboed.com> 2013-09-26 06:21:05 UTC ---
Review of attachment 255793:
 --> (https://bugzilla.gnome.org/review?bug=680087&attachment=255793)

Overall I'm not entirely convinced by this patch.

If you have a long (say 1 hour) flv ... and you seek to almost the end you'd
have to wait for everything to be downloaded, even if the remote server
supports range queries.

It would make a lot more sense to add scanning as mentionned in bug #674790 .

Also this patch seems to remove some pre-existing behaviour. Has this been
checked in all other scenarios (pull/push and with/without index) ?

::: gst/flv/gstflvdemux.c
@@ +1947,2 @@
+        /* parse tag data */
+        if (demux->seek_state == FLV_SEEK_STATE_PARSE_TAG_DATA) {

seek_state should be initialized in the right location before it can be used.

In _demux_cleanup() for example ?

@@ +2613,3 @@
   }

+  /* ST rewrite this piece of code to converge the pull mode and push mode
seek */

References to private bugtrackers are of no use for people who can't access it.

Instead explain what the problem is and why it needs to be fixed this way.

@@ -2591,3 @@
     demux->seek_event = gst_event_ref (event);
-
-    /* set the building_index flag so that only one thread can setup the

Where has this code gone ?

::: gst/flv/gstflvdemux.h
@@ +67,2 @@
   /* <private> */
+

Don't include empty changes.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.