[Bug 668091] qtmux: Add support for DASH

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=668091
  GStreamer | gst-plugins-good | unspecified

--- Comment #4 from Thiago Sousa Santos <thiago.sousa.santos at collabora.co.uk> 2013-09-26 22:36:48 UTC ---
Review of attachment 252613:
 --> (https://bugzilla.gnome.org/review?bug=668091&attachment=252613)

Just a minor nitpicking, otherwise looks good to me.

It would be nice to have this early in this cycle so we get proper testing
before release. Going to look at the bug for the fragments support in qtmux to
get it pushed, too.

::: gst/isomp4/atoms.c
@@ -241,2 +241,2 @@
 static void
-atom_ftyp_init (AtomFTYP * ftyp, guint32 major, guint32 version, GList *
brands)
+atom_brands_init (AtomFTYP * ftyp, guint32 fourcc, guint32 major,

I'd think it is better to rename this to 'AtomBrands' instead of leaving it as
AtomFTYP as it can also be an STYP now.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.