[Bug 706441] adder: Rework/review the way we handle flushing

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=706441
  GStreamer | gst-plugins-base | 1.x

--- Comment #11 from Edward Hervey <bilboed at bilboed.com> 2013-09-27 09:13:36 UTC ---
Review of attachment 255147:
 --> (https://bugzilla.gnome.org/review?bug=706441&attachment=255147)

::: tests/check/elements/adder.c
@@ +1235,3 @@
   adder_src = gst_element_get_static_pad (adder, "src");
   fail_if (GST_PAD_IS_FLUSHING (adder_src));
+  gst_pad_send_event (adder_src, gst_event_new_flush_start ());

you're changing the nature of this test with this.

Shouldn't you add a different unit test ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.