[Bug 708940] New: GstX264enc never disables VFR when framerate is known

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=708940
  GStreamer | gst-plugins-ugly | 1.x

           Summary: GstX264enc never disables VFR when framerate is known
    Classification: Platform
           Product: GStreamer
           Version: 1.x
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-ugly
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: michael.esemplare at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=255945)
 View: https://bugzilla.gnome.org/attachment.cgi?id=255945
 Review: https://bugzilla.gnome.org/review?bug=708940&attachment=255945

Patch

I have a video file with a fixed framerate, however the framerate is never
used. My resulting encoded files always end up with VFR (0/1).

GstX264Enc sets the default x264Params with x264_param_default from libx264(
which b_vfr_input is set to true:
http://git.videolan.org/gitweb.cgi?p=x264.git;a=blob;f=common/common.c )

I noticed that libx264 sets b_vfr_input=0 in the zerolatency profile. 
http://git.videolan.org/gitweb.cgi?p=x264.git;a=blob;f=common/common.c#l382

Would this parameter be something that could be exposed to the plugin, such
that the user can choose if they wish to use VFR.

/* VFR input.  If 1, use timebase and timestamps for ratecontrol purposes.
 * If 0, use fps only. */

The attached patch sets the b_vfr_input=false when info->fps_d/n are set.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.