[Bug 708991] [PATCH] invalid musicbrainz discids because of trailing data tracks

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sat Sep 28 04:55:21 PDT 2013


https://bugzilla.gnome.org/show_bug.cgi?id=708991
  GStreamer | gst-plugins-base | git

--- Comment #1 from Johannes Dewender <gnome at JonnyJD.net> 2013-09-28 11:55:17 UTC ---
Created an attachment (id=255979)
 View: https://bugzilla.gnome.org/attachment.cgi?id=255979
 Review: https://bugzilla.gnome.org/review?bug=708991&attachment=255979

proposed fix, fetch the number of the last audio track

I add a patch that fixes this the same as recent versions of libdiscid:
https://github.com/metabrainz/libdiscid/blob/eef09db2bcf5c611025fe62215c1435d7b9d9b88/src/toc.c#L54

Previous versions of libdiscid did it different. This way has the advantage to
cope with discs that have multiple data tracks.

Also note that data tracks at the start of the TOC (like done with PC games
sometimes) don't get cut off, since the first track is expected to be track 1.

Tested with the test program mentioned above and various discs (with and
without data tracks). Compared with the result from libdiscid.

The patch was done against current git master.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list